Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mpi test #956

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix mpi test #956

merged 5 commits into from
Feb 7, 2024

Conversation

epolack
Copy link
Collaborator

@epolack epolack commented Feb 6, 2024

Sorry, overlooked because MPI test lately fail randomly for no apparent reason…

@epolack epolack marked this pull request as ready for review February 6, 2024 13:11
@@ -190,7 +190,7 @@ BLAS.set_num_threads(N)
where `N` is the number of threads you desire.
To **check the number of BLAS threads** currently used, you can use
```julia
Int(ccall((BLAS.@blasfunc(openblas_get_num_threads), BLAS.libblas), Cint, ()))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Int(…) really complicated and does not work on my machine or cluster. get_num_threads() does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see next line; we depend on a newer version so just scrap this.

Copy link
Member

@antoine-levitt antoine-levitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after the minor comment

@@ -190,7 +190,7 @@ BLAS.set_num_threads(N)
where `N` is the number of threads you desire.
To **check the number of BLAS threads** currently used, you can use
```julia
Int(ccall((BLAS.@blasfunc(openblas_get_num_threads), BLAS.libblas), Cint, ()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see next line; we depend on a newer version so just scrap this.

@epolack epolack enabled auto-merge (squash) February 6, 2024 19:30
@antoine-levitt antoine-levitt merged commit 7f7e5d6 into JuliaMolSim:master Feb 7, 2024
7 of 8 checks passed
@epolack epolack deleted the fix_mpi_test branch February 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants