MTS implementation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbesancon
reviewed
Jul 6, 2021
matbesancon
reviewed
Jul 6, 2021
matbesancon
reviewed
Jul 6, 2021
matbesancon
reviewed
Jul 6, 2021
src/algorithms/mts.jl
Outdated
Comment on lines
54
to
61
| if debugging[] | ||
| function Base.setproperty!(workspace::MTSWorkspace, name::Symbol, x) | ||
| if name in [:optimal_x, :optimal_ind, :optimal_val] | ||
| println("New ", name, ": ", x) | ||
| end | ||
| setfield!(workspace, name, x) | ||
| end | ||
| end |
There was a problem hiding this comment.
don't forget to remove it
matbesancon
reviewed
Jul 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 68.42% 70.69% +2.27%
==========================================
Files 36 37 +1
Lines 2714 2962 +248
==========================================
+ Hits 1857 2094 +237
- Misses 857 868 +11
Continue to review full report at Codecov.
|
Closed
Closed
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mohamed Tarek <mohamed82008@gmail.com>
matbesancon
reviewed
Jul 24, 2021
matbesancon
reviewed
Jul 24, 2021
matbesancon
reviewed
Jul 24, 2021
|
|
||
| """ | ||
| The Griewank problem. | ||
| From Ali, Khompatraporn, and Zabinsy (2005, p 559). |
There was a problem hiding this comment.
Give a mathematical expression for the problem formulation here
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
mohamed82008
reviewed
Aug 3, 2021
mohamed82008
reviewed
Aug 3, 2021
mohamed82008
reviewed
Aug 3, 2021
mohamed82008
reviewed
Aug 3, 2021
|
Looks good overall. I left a few minor comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation, testcases and doc of algorithm in paper Lin-Yu Tseng and Chun Chen, 2008