Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Literate at version 2 for package nmf, (keep existing compat) #135

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the Literate package to 2 for package nmf.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@zsteve zsteve force-pushed the compathelper/new_version/2021-09-12-00-25-22-355-02873622927 branch from d684fea to fda8819 Compare September 12, 2021 00:25
@coveralls
Copy link

coveralls commented Sep 12, 2021

Pull Request Test Coverage Report for Build 1226182541

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.424%

Totals Coverage Status
Change from base Build 1226181847: 0.0%
Covered Lines: 508
Relevant Lines: 538

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #135 (01a06bd) into master (264e0c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          12       12           
  Lines         538      538           
=======================================
  Hits          508      508           
  Misses         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264e0c0...01a06bd. Read the comment docs.

@zsteve zsteve merged commit 2953728 into master Sep 12, 2021
@zsteve zsteve deleted the compathelper/new_version/2021-09-12-00-25-22-355-02873622927 branch September 12, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants