Distinguish between StateNode creation and lookup
#100
Conversation
| @@ -183,13 +183,13 @@ function clear_tree!(p::MCTSPlanner{S,A}) where {S,A} p.tree = nothing end | |||
|
|
|||
| Return the StateNode in the tree corresponding to s. If there is no such node, add it using the planner. | |||
| """ | |||
| function get_state_node(tree::MCTSTree, s, planner::MCTSPlanner) | |||
There was a problem hiding this comment.
This function does not seem to be used anywhere, I think it can be removed?
Codecov ReportBase: 86.62% // Head: 86.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 86.62% 86.69% +0.06%
==========================================
Files 10 10
Lines 486 481 -5
==========================================
- Hits 421 417 -4
+ Misses 65 64 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Unless @zsunberg or anyone else objects, I will merge this since it seems to trip up people regularly (https://github.com)/JuliaPOMDP/MCTS.jl/issues/63 |
BoZenKhaa
requested review from
rejuvyesh and
zsunberg
and removed request for
zsunberg
There was a problem hiding this comment.
This looks good to me. The concept of "creating" a state node is a bit weird in MCTS because you have to add to the tree to create one. But I agree that this is clearer than it was before. Thanks @BoZenKhaa for your thoughtful contribution.
Addresses #63, which in at least one occurrence of the issue was caused by incorrectly dispatching to the
StateNodeconstructor in MDP where states were integers.