n == 0 should imply infinite criteria value #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes JuliaPOMDP#30 If the value for this node/action is already an infinity, then we keep that infinity value as the criterion value, since UCB cannot change it. At best, if the value were -infinity and n==0, we get -Inf + Inf == NaN, which would not be good. Prior to this fix, if node values are initialized to zero and rewards are positive, sometimes the first node would be explored twice before the second node gets explored the first time.
|
Thanks so much for your contribution and new clarity in understanding the cases! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #30
If the value for this node/action is already an infinity,
then we keep that infinity value as the criterion value, since UCB cannot change it.
At best, if the value were -infinity and n==0, we get -Inf + Inf == NaN, which would not be good.
Prior to this fix, if node values are initialized to zero and rewards are positive,
sometimes the first node would be explored twice before the second node gets explored the first time.