-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a uniform distribution over a collection of objects #19
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0b44190
added a uniform distribution over a collection of objects
zsunberg 784c10d
Merge branch 'master' into uniform
zsunberg 56859d9
Uniform checks uniqueness, added UnsafeUniform
zsunberg 8db5e7b
put code into common section
zsunberg 47936b3
deleted commented code
zsunberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,9 @@ BoolDistribution | |
```@docs | ||
Deterministic | ||
``` | ||
|
||
## Uniform | ||
|
||
```@docs | ||
Uniform | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
""" | ||
Uniform(collection) | ||
|
||
Create a categorical distribution over a collection of objects. | ||
""" | ||
mutable struct Uniform{C, T} | ||
collection::C | ||
_set::Union{Set{T}, Nothing} # keep track of what's in the collection to make pdf more efficient | ||
end | ||
|
||
Uniform(c) = Uniform{typeof(c), eltype(c)}(c, nothing) | ||
Uniform(c::Set) = Uniform{typeof(c), eltype(c)}(c, c) | ||
|
||
rand(rng::AbstractRNG, d::Uniform) = rand(rng, d.collection) | ||
rand(rng::AbstractRNG, d::Uniform{<:NamedTuple}) = d.collection[rand(rng, 1:length(d.collection))] | ||
|
||
support(d::Uniform) = d.collection | ||
sampletype(::Type{Uniform{C, T}}) where {C,T} = T | ||
|
||
function pdf(d::Uniform, s) | ||
d._set = something(d._set, Set(d.collection)) | ||
if s in d._set | ||
return 1/length(d.collection) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
else | ||
return 0.0 | ||
end | ||
end | ||
|
||
mode(d::Uniform) = mode(d.collection) | ||
mean(d::Uniform) = mean(d.collection) | ||
|
||
function weighted_iterator(d::Uniform) | ||
p = 1/length(d.collection) | ||
return (x=>p for x in d.collection) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
d = Uniform([1]) | ||
|
||
@test rand(d) == 1 | ||
@test rand(MersenneTwister(4), d) == 1 | ||
@test collect(support(d)) == [1] | ||
@test sampletype(d) == typeof(1) | ||
@test sampletype(typeof(d)) == typeof(1) | ||
@test pdf(d, 0) == 0.0 | ||
@test pdf(d, 1) == 1.0 | ||
@test mode(d) == 1 | ||
@test mean(d) == 1 | ||
@test typeof(mean(d)) == typeof(mean([1])) | ||
|
||
d2 = Uniform((:symbol,)) | ||
@test rand(d2) == :symbol | ||
@test rand(MersenneTwister(4), d2) == :symbol | ||
@test collect(support(d2)) == [:symbol] | ||
@test sampletype(d2) == typeof(:symbol) | ||
@test sampletype(typeof(d2)) == typeof(:symbol) | ||
@test pdf(d2, :another) == 0.0 | ||
@test pdf(d2, :symbol) == 1.0 | ||
@test mode(d2) == :symbol |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear about the rationale here. If you are allowing for non-sets and converting it into sets and giving them equal weights, then how can you sample uniformly from the collection which might have multiple instances of the same and therefore higher weight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thanks, I need to redesign this.