Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove abstract types from rollout simulator #441

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Remove abstract types from rollout simulator #441

merged 1 commit into from
Mar 17, 2023

Conversation

BoZenKhaa
Copy link
Contributor

@BoZenKhaa BoZenKhaa commented Nov 3, 2022 •
edited
Loading

The UnionAll types in the RolloutSimulator were causing dynamic dispatch (according to JET). Here, I replace the nothing with default values used in the nothing if-checks.

@BoZenKhaa BoZenKhaa closed this Nov 3, 2022
@BoZenKhaa BoZenKhaa reopened this Nov 3, 2022
@WhiffleFish WhiffleFish merged commit 967fca1 into JuliaPOMDP:master Mar 17, 2023
@johannes-fischer johannes-fischer mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsunberg zsunberg Awaiting requested review from zsunberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoZenKhaa @WhiffleFish