Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat #175

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Update compat #175

merged 1 commit into from
Dec 12, 2019

Conversation

JackDunnNZ
Copy link
Contributor

Saw the new release got held up in the registry and hoped this might help

Here were the packages I got when installing on Julia 1.2

BinDeps v1.0.0
Compat v2.2.0
HTTPClient v0.2.1
LibExpat v0.5.0
Libz v1.0.0
URIParser v0.4.0

and on Julia 1.3 the only difference was LibExpat v0.6

I tried to figure out some reasonable bounds:

  • BinDeps 1.0 dropped support for Julia 0.6
  • Compat 2 or 3 seems reasonable and not overly restrictive
  • HTTPClient only has versions 0.1-0.2 and hasn't been updated in years
  • LibExpat 0.5 was the first release to drop Julia 0.6 support, and 0.6 has just come out
  • Libz 1.0 was the first to support 0.7+
  • URIParser 0.4 was the first to drop Julia 0.6, and is the most recent release

@timholy
Copy link
Member

timholy commented Dec 12, 2019

LGTM, but I don't know enough about this package to feel confident about merging this.

@nalimilan
Copy link
Member

I'm not sure either but your analysis sounds reasonable...

@nalimilan nalimilan merged commit 44e3b07 into JuliaPackaging:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants