-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build recipe for LLVM9 #296
Conversation
Should we update the pipeline to skip this? The @ wasn't initially expected. |
@staticfloat would an assert build be something like |
Okay reverted back to splitting the native and cross-compile stage: For future reference I almost got Native to work on windows, but got stuck on include errors.
|
Ah is Yggdrasil doing some sneaky parsing and having multiple |
Any chance we could include the WebAssembly target with this? |
I am so confused by this error. |
Actually yes, that is needed since Base Julia know has this flag on by default. |
Any plan on maintaining a Julia-release-compatible LLVM recipe? Julia 1.3.0 is built with WASM disabled. |
Actually yes! We only build WASM for LLVM 8 which is Julia 1.4 only. See https://github.com/JuliaPackaging/Yggdrasil/pull/296/files#diff-08724ed72679c754126058e3bfd19c92R111-R113 |
Valentin, just so you know, I needed to multiversion OpenBLAS as well, and I decided that I liked putting the common stuff into an |
I think there are two patches that still need forward porting got LLVM 9, but otherwise I am rather pleased to have builds for all platforms. LLVM8 and co. can follow later |
This is pretty incredible. Shall we merge this, then we can open separate PRs for v6 and v8? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🙂
Update the title? Or at least the commit message when merging |
based of https://github.com/staticfloat/LLVMBuilder also add Julia patches for: - LLVM6 used by Julia 1.0-1.3 - LLVM8 used by Julia 1.4 Co-authored-by: Elliot Saba <staticfloat@gmail.com>
Ready to land from my side. |
Yay! 🚀 |
Based on https://github.com/staticfloat/LLVMBuilder
Questions: