Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor for more scalable design #17

Closed
wants to merge 4 commits into from
Closed

Conversation

Roger-luo
Copy link
Collaborator

@Roger-luo Roger-luo commented Aug 11, 2019

Based on #13

@Roger-luo
Copy link
Collaborator Author

Roger-luo commented Aug 23, 2019

Hi, guys I'm thinking about how to write a general edge iterator based on unit cells, I'm wondering implementing it in this way is sufficient:

  1. unit cells provides an edge iterator that iterates its effective edge given its position (e.g for square lattice, its unit cell location can be (1, 1)), hypercude can be (1, 1) as well.
  2. we iterate through given geometry (such as Plane, Sphere etc.) at each iteration state, we iterate the unit cell so we get a set of effective edges generated from unit cell

However, this will make our previous interface change a bit, e.g instead of saying we are going to have a 4x4 square lattice, we will say we are going to have a 2D plane of size 4x4 with square unit cells (which means there are 4x4 square unit cells)

Since I think it is harder to generate proper size for unit cells than just provide each unit cell's position and check if the geometry fits given unit cell.

@Roger-luo Roger-luo closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant