Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twiny #3532

Closed
wants to merge 2 commits into from
Closed

Twiny #3532

wants to merge 2 commits into from

Conversation

mmikhasenko
Copy link
Contributor

@mmikhasenko mmikhasenko commented Jun 2, 2021

adds twiny() function that is analogous to twinx()
Close #2579

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3532 (e83c6e6) into master (e43f3ee) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3532      +/-   ##
==========================================
- Coverage   64.35%   64.25%   -0.11%     
==========================================
  Files          27       27              
  Lines        6612     6621       +9     
==========================================
- Hits         4255     4254       -1     
- Misses       2357     2367      +10     
Impacted Files Coverage Δ
src/Plots.jl 31.42% <ø> (ø)
src/layouts.jl 62.19% <0.00%> (-1.40%) ⬇️
src/types.jl 47.82% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43f3ee...e83c6e6. Read the comment docs.

@isentropic
Copy link
Member

I think we can merge this right away if we have the accompanying docs. Since twinxis not even oficially documented, would you please add a new subsection under http://docs.juliaplots.org/latest/layouts/#Adding-Subplots-incrementally and document a brief usage of twinx, twiny? Once the corresponing PR with docs lands to PlotDocs repo we can merge both right away.

@BeastyBlacksmith
Copy link
Member

I am actually a bit hesitant here, because twinx is causing a lot of trouble (which may be why it is undocumented so far). I'd prefer having the "providing additional scales" sorted out before adding more of them

@isentropic
Copy link
Member

That's fair, let's hold on this then

@mmikhasenko
Copy link
Contributor Author

@BeastyBlacksmith
Are issues with twinx collected somewhere?

  • I noticed that it does not work correctly with pgfplotsx(), particularly with the heatmap

@BeastyBlacksmith
Copy link
Member

https://github.com/JuliaPlots/Plots.jl/issues?q=is%3Aissue+is%3Aopen+twinx

@BeastyBlacksmith BeastyBlacksmith marked this pull request as draft July 5, 2021 15:57
@t-bltg t-bltg added the WIP Work in progress, do not merge! label Jul 6, 2021
@t-bltg t-bltg mentioned this pull request Nov 1, 2022
@t-bltg
Copy link
Member

t-bltg commented Nov 1, 2022

Superseded by #4488.

@t-bltg t-bltg closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress, do not merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twiny() ?
4 participants