Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite custom formatter for with vline! #4619

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

daschw
Copy link
Member

@daschw daschw commented Jan 4, 2023

fix #4538

plot(rand(4) .* 10^6, rand(4) .* 10^6, xformatter=:plain, yformatter=:plain)
vline!([10^6])

vline_formatter

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 90.65% // Head: 90.78% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (6c8902b) compared to base (3fe21ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4619      +/-   ##
==========================================
+ Coverage   90.65%   90.78%   +0.13%     
==========================================
  Files          41       41              
  Lines        8772     8773       +1     
==========================================
+ Hits         7952     7965      +13     
+ Misses        820      808      -12     
Impacted Files Coverage Δ
src/args.jl 84.98% <100.00%> (ø)
src/backends/gr.jl 91.66% <0.00%> (+<0.01%) ⬆️
RecipesPipeline/src/utils.jl 97.26% <0.00%> (+1.36%) ⬆️
RecipesPipeline/src/series.jl 93.58% <0.00%> (+2.56%) ⬆️
src/examples.jl 99.20% <0.00%> (+3.17%) ⬆️
RecipesPipeline/src/RecipesPipeline.jl 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith BeastyBlacksmith merged commit 2ec18f0 into JuliaPlots:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vline! overrides previously set formatter
2 participants