Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Python 3.6 instead of 3.7 #129

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 47 additions & 7 deletions src/Conda.jl
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,6 @@ function _installer_url()
elseif Compat.Sys.islinux()
res *= "Linux"
elseif Compat.Sys.iswindows()
if MINICONDA_VERSION == "3"
# Quick fix for:
# * https://github.com/JuliaLang/IJulia.jl/issues/739
# * https://github.com/ContinuumIO/anaconda-issues/issues/10082
# * https://github.com/conda/conda/issues/7789
res = "https://repo.continuum.io/miniconda/Miniconda$(MINICONDA_VERSION)-4.5.4-"
end
res *= "Windows"
else
error("Unsuported OS.")
Expand All @@ -147,6 +140,17 @@ end
"Suppress progress bar in continuous integration environments"
_quiet() = get(ENV, "CI", "false") == "true" ? `-q` : ``

"""
Python version to be used when `MINICONDA_VERSION == "3"`. As it
takes time for conda packages to be registered after new Python is
released, it is useful to delay updating Python interpreter.
See: https://github.com/JuliaPy/Conda.jl/issues/127

Note that https://github.com/JuliaPy/Conda.jl/issues/125 must be
resolved before bumping this to 3.7.
"""
const _default_python3 = "python=3.6"

"Install miniconda if it hasn't been installed yet; _install_conda(true) installs Conda even if it has already been installed."
function _install_conda(env::Environment, force::Bool=false)
if force || !isfile(Conda.conda)
Expand All @@ -168,6 +172,10 @@ function _install_conda(env::Environment, force::Bool=false)
run(Cmd(`$installer /S /AddToPath=0 /RegisterPython=0 /D=$PREFIX`, windows_verbatim=true))
end
Conda.add_channel("defaults")
if MINICONDA_VERSION == "3"
add(_default_python3, env)
pin(_default_python3, env)
end
# Update conda because conda 4.0 is needed and miniconda download installs only 3.9
runconda(`update $(_quiet()) -y conda`)
end
Expand Down Expand Up @@ -287,4 +295,36 @@ function rm_channel(channel::AbstractString, env::Environment=ROOTENV)
runconda(`config --remove channels $channel --force`, env)
end

"""
Conda.pin(sepc, [env])

Pin version of given package. Use `Conda.free` to unpin the package.

# Examples
```
julia> Conda.pin("matplotlib<3")
julia> Conda.pin("pandas=0.23")
julia> Conda.pin("defaults::numpy")
```
"""
function pin(spec::AbstractString, env::Environment=ROOTENV)
runconda(`config --add pinned_packages $spec`, env)
end

"""
Conda.free(sepc, [env])

Remove `spec` from `pinned_packages` configuration.

# Examples
```
julia> Conda.free("matplotlib<3")
julia> Conda.free("pandas=0.23")
julia> Conda.free("defaults::numpy")
```
"""
function free(spec::AbstractString, env::Environment=ROOTENV)
runconda(`config --remove pinned_packages $spec`, env)
end

end
11 changes: 10 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ using Compat.Test

exe = Compat.Sys.iswindows() ? ".exe" : ""

is_fresh = !isdir(Conda.PYTHONDIR)
Conda.update()

env = :test_conda_jl
Expand All @@ -14,7 +15,11 @@ rm(Conda.prefix(env); force=true, recursive=true)
Conda.add("curl", env)

@testset "Install Python package" begin
Conda.add("python=3.6", env) # 3.7 doesn't work on Windows at the moment
# Conda.pin below is redundant and `Conda.add("python=3.6", env)`
# is actually enough. The intention is to check the case where
# `pin` is called before `add`.
Conda.pin("python=3.6", env) # 3.7 doesn't work on Windows at the moment
Conda.add("python", env)
pythonpath = joinpath(Conda.python_dir(env), "python" * exe)
@test isfile(pythonpath)

Expand All @@ -40,6 +45,10 @@ pythonpath = joinpath(Conda.PYTHONDIR, "python" * exe)
@test isfile(pythonpath)
pyversion = read(`$pythonpath -c "import sys; print(sys.version)"`, String)
@test pyversion[1:1] == Conda.MINICONDA_VERSION
if is_fresh && Conda.MINICONDA_VERSION == 3
@test startswith(pyversion, "3.6")
@test_throws Exception Conda.add("python=3.7")
end

Conda.add_channel("foo", env)
@test Conda.channels(env) == ["foo", "defaults"]
Expand Down