-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin implementing null backend #29
Conversation
Thanks, be my guest :) Off the top of my head, these API functions will need to change when backend is Null:
|
|
Oops - didn't mean to close that 😆 |
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 93.32% 90.78% -2.54%
==========================================
Files 7 7
Lines 584 597 +13
==========================================
- Hits 545 542 -3
- Misses 39 55 +16
Continue to review full report at Codecov.
|
Looks good so far!
It would be nice to test this, at least a bit. Maybe the tests could look at |
On |
Here, I just have it return nothing up at the top after printing the message (that's what I originally intended, and just forgot 🤦 ). Is that OK? |
Working on this now |
Not sure if there's a more elegant way to do this, maybe using ReTest.jl or something. But this works. Can test locally by doing:
|
Looks great, all your comments are fine. Boldly merging even though there are 2 tests still running. Thanks very much for your contribution. |
You're welcome! Thanks for quick review and help :-) |
If you'd rather deal with this yourself, fine with me if you want to just close this. Closes #28
I'm not totally sure how to test this, since it would require getting the workflow runner to install the appropriate packages separately to make the other tests pass. But if you're ok with it, I think adding a disclaimer that this is untested would be ok 🤷