determine libpython at Pkg.build time, not at runtime #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested locally and it decreases load time from ~4s to ~2s. |
|
I just pushed a few precompilations that get it down to 1.3 seconds on my machine. (I'm guessing the improvements on Windows, compared to the old PyCall, may be even greater.) |
stevengj
added a commit
that referenced
this pull request
Jul 23, 2015
determine libpython at Pkg.build time, not at runtime
|
|
stevengj
added a commit
that referenced
this pull request
Jul 24, 2015
Fix misnamed variable introduced by in #169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #167.
With
Base.compile(:PyCall), the load time is currently down to about 2 seconds on my machine. I'm not sure how to get it down further, although it should be possible.cc: @malmaud, @jakebolewski