Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: MistyClosures v1.0.0 #108007

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: dbe65cb8-6be2-42dd-bbc5-4196aaced4f4
Repo: https://github.com/compintell/MistyClosures.jl.git
Tree: 3f7cb6a8703b9b269d888e6b1da2076bf01e410e

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in compintell/MistyClosures.jl May 31, 2024
* Basics

* Add inference test

* Only run on 1.10

* Add inner constructor

* Enable default constructor

* Ensure that default constructor works

* Add small example in readme

* Fix typo

* Set to version 1

* Tweak Project.toml
Copy link
Contributor

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@wsmoses
Copy link

wsmoses commented Jun 2, 2024

Does this potentially make sense to move into Julia proper rather than a package? [noblock]

@willtebbutt
Copy link
Contributor

[noblock] I would have no problem with this going in to Julia proper at some point, but I'd rather just make it a package for now in the interest of time.

@willtebbutt
Copy link
Contributor

[noblock] @wsmoses would you mind [noblock]ing your comment so that this can be merged?

@wsmoses
Copy link

wsmoses commented Jun 4, 2024

Sorry, am on travel presently. [noblock].

That said if moving into Julia proper is the goal, I feel like it might be productive to make an RFC / PR to Julia?

I know a lot of compiler things that might benefit from this so it's worth getting the design right from the get go.

@willtebbutt
Copy link
Contributor

[noblock] I take your point -- I'll open an RFC / PR to Julia proper to get the ball rolling once this package is registered.

p.s. sorry, it still looks like your first comment is blocking merging 😬

@JuliaTagBot JuliaTagBot merged commit 32a5b6b into master Jun 6, 2024
17 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-mistyclosures-dbe65cb8-v1.0.0-6a36c605fb branch June 6, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants