Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: WaterLily v0.2.2 #41953

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: ed894a53-35f9-47f1-b17f-85db9237eebd
Repo: https://github.com/weymouth/WaterLily.jl.git
Tree: 782adb7f8ceebc2247046a10d0cc6a5a93c42bc1

Registrator tree SHA: c7e033175c3b9b466fb2cc8beab47042878a66b0
JuliaRegistrator referenced this pull request in WaterLily-jl/WaterLily.jl Aug 1, 2021
Optimized loops for Julia 1.6 and got rid of allocations for moving geometries. WaterLily 0.2.2 is around twice as fast for Julia 1.6 than version 0.2.0 for statics goemetries and around 4 x faster for moving geometries.
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 1, 2021 18:09 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Does not meet sequential version number guideline: version 0.2.2 skips over 0.2.1

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@giordano
Copy link
Member

giordano commented Aug 1, 2021

@weymouth did you skip version number on purpose?

@weymouth
Copy link
Contributor

weymouth commented Aug 1, 2021

I did version 0.2.1 a few days ago not realizing that I needed to manually sync with the registry. I tried to rename this version 0.2.1, but register bot didn't like that either.

If it's ok to skip registering 0.2.1, let's just do that and move on.

@giordano
Copy link
Member

giordano commented Aug 1, 2021

I tried to rename this version 0.2.1, but register bot didn't like that either.

My educated guess is that that's because you're manually creating the git tags before successful registration, instead of letting TagBot create them for you after successful registration of a version. You should simply not create git tags manually.

@weymouth
Copy link
Contributor

weymouth commented Aug 1, 2021

Will do from now on.

@giordano giordano merged commit 32418e5 into master Aug 1, 2021
@giordano giordano deleted the registrator/waterlily/ed894a53/v0.2.2 branch August 1, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants