-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: LSL v0.1.0 #4256
New package: LSL v0.1.0 #4256
Conversation
JuliaRegistrator
commented
Oct 10, 2019
•
edited
Loading
edited
- Registering package: LSL
- Repository: https://github.com/samuelpowell/LSL.jl
- Created by: @samuelpowell
- Version: v0.1.0
- Commit: 2af3d560b3f1157f1fb8a1448c9c4ddd71814395
- Reviewed by: @samuelpowell
- Reference: Register v0.1.0 samuelpowell/LSL.jl#9 (comment)
151a810
to
669e63d
Compare
Can you retrigger to resolve the conflict? Also, how about calling this Edit: nvm, this was wrapping a lsl library. |
669e63d
to
5da19d2
Compare
@fredrikekre retriggered. And yes, this wraps a library called lsl, which has various language bindings which use this naming format. |
Your Specifically, your pull request does not meet the following guidelines:
It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.
On a separate note, I see that you are registering a release with a version number of the form Does your package have a stable public API? If so, then it's time for you to register version If your package does not yet have a stable public API, then of course you are not yet ready to release version [noblock] |
5da19d2
to
13435a8
Compare
Your Specifically, your pull request does not meet the following guidelines:
If you want to prevent this pull request from being auto-merged, simply leave a comment. (If you want to post a comment without blocking auto-merging, you must include the text It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.
On a separate note, I see that you are registering a release with a version number of the form Does your package have a stable public API? If so, then it's time for you to register version If your package does not yet have a stable public API, then of course you are not yet ready to release version [noblock] |
@fredrikekre I have addressed your comments and those of zeptodoctor, this should be good to merge now. |
UUID: 57c3d5b1-721f-43a0-b20c-e9152d812276 Repo: https://github.com/samuelpowell/LSL.jl.git Tree: 55de0997432139fba3aec4c2f429f389df88af2a Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
13435a8
to
8916135
Compare
Your Specifically, your pull request does not meet the following guidelines:
If you want to prevent this pull request from being auto-merged, simply leave a comment. (If you want to post a comment without blocking auto-merging, you must include the text It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.
On a separate note, I see that you are registering a release with a version number of the form Does your package have a stable public API? If so, then it's time for you to register version If your package does not yet have a stable public API, then of course you are not yet ready to release version [noblock] |
I've created release |