Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: LSL v0.1.0 #4256

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 10, 2019

@fredrikekre
Copy link
Member

fredrikekre commented Oct 16, 2019

Can you retrigger to resolve the conflict? Also, how about calling this LabStreamingLayer (LabStreamingLayers?)

Edit: nvm, this was wrapping a lsl library.

@samuelpowell
Copy link

@fredrikekre retriggered. And yes, this wraps a library called lsl, which has various language bindings which use this naming format.

@ghost
Copy link

ghost commented Oct 17, 2019

Your new package pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • Name does not meet all of the following: starts with a capital letter, ASCII alphanumerics only, ends in lowercase
  • Name is not at least five characters long
  • The following dependencies do not have a compat entry that has an upper bound: CEnum, BinaryProvider, LightXML

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@ghost
Copy link

ghost commented Oct 25, 2019

Your new package pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • Name does not meet all of the following: starts with a capital letter, ASCII alphanumerics only, ends in lowercase
  • Name is not at least five characters long

If you want to prevent this pull request from being auto-merged, simply leave a comment.

(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)


It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@samuelpowell
Copy link

@fredrikekre I have addressed your comments and those of zeptodoctor, this should be good to merge now.

UUID: 57c3d5b1-721f-43a0-b20c-e9152d812276
Repo: https://github.com/samuelpowell/LSL.jl.git
Tree: 55de0997432139fba3aec4c2f429f389df88af2a

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@ghost
Copy link

ghost commented Oct 25, 2019

Your new package pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • Name does not meet all of the following: starts with a capital letter, ASCII alphanumerics only, ends in lowercase
  • Name is not at least five characters long

If you want to prevent this pull request from being auto-merged, simply leave a comment.

(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)


It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@fredrikekre fredrikekre merged commit 3b8d17c into master Oct 28, 2019
@fredrikekre fredrikekre deleted the registrator/lsl/57c3d5b1/v0.1.0 branch October 28, 2019 08:53
@julia-tagbot
Copy link

julia-tagbot bot commented Oct 28, 2019

I've created release v0.1.0, here it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants