Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: QuantumControl v0.0.1 #42833

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Aug 13, 2021

@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 13, 2021 17:34 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@goerz
Copy link
Member

goerz commented Aug 13, 2021

[noblock]

I don't understand. My Project.toml contains

  [compat]
  julia = "1.6"
  QuantumControlBase = "^0"

So there is a compat entry for QuantumControlBase, despite what the bot thinks.

@giordano
Copy link
Member

giordano commented Aug 13, 2021

@DilumAluthge any clue what's going on? Same issue in #42793

[noblock]

@giordano
Copy link
Member

Oh, now I understand:

QuantumControlBase = "^0"

is not a finite number of breaking changes. You need to specify something like

QuantumControlBase = "0.1"

(I don't know what are the actual versions of QuantumControlBase available)

[noblock]

UUID: 8a270532-f23f-47a8-83a9-b33d10cad486
Repo: https://github.com/QuantumControl-jl/QuantumControl.jl.git
Tree: cb1ec0117cd63a09b53c08fbba794040245bd301

Registrator tree SHA: f960ef1f24e90d1b5256359075cd8612a195eac5
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/quantumcontrol/8a270532/v0.0.1 branch from 326dd93 to ff4babc Compare August 13, 2021 18:02
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 13, 2021 18:03 Inactive
@goerz
Copy link
Member

goerz commented Aug 13, 2021

Ah, I see!

Seems maybe a little overbearing, at least for 0.* releases. At least in my interpretation of semver, "breaking changes contracts" only start at 1.0.0, or arguably0.1.0, but ok ;-)

I'm trying now with ^0.0, which seems to work (also for #42793) 👍. In any case, these are all 0.0.1 releases, which are mostly placeholders until the first functional 0.1 release. It's just that the standard Github Action for running the tests refuses to work with unregistered dependencies. Since there are a bunch of tightly coupled packages, I do need to integration-test them with each other while working towards an actual release.

@giordano Thanks for your help!

[noblock]

@JuliaTagBot JuliaTagBot merged commit 60bc8de into master Aug 16, 2021
@JuliaTagBot JuliaTagBot deleted the registrator/quantumcontrol/8a270532/v0.0.1 branch August 16, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants