Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: WinRPM v0.4.3 #6375

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Dec 7, 2019

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2019

Your new version pull request does not meet the following guidelines for auto-merging:

  • The following dependencies do not have a compat entry that has an upper bound: BinDeps, Compat, HTTPClient, LibExpat, Libz, URIParser
  • A patch release is not allowed to narrow the supported range of Julia versions

Note: If your package works for the current version x.y.z of a dependency foo, then a compat entry foo = x.y.z implies a compatibility upper bound for packages following semver. You can additionally include earlier versionsyour package is compatible with. See [https://julialang.github.io/Pkg.jl/v1/compatibility/.] for details.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@nalimilan
Copy link
Contributor

A patch release is not allowed to narrow the supported range of Julia versions

Note: If your package works for the current version x.y.z of a dependency foo, then a compat entry foo = x.y.z implies a compatibility upper bound for packages following semver. You can additionally include earlier versionsyour package is compatible with. See [https://julialang.github.io/Pkg.jl/v1/compatibility/.] for details.

We now require Julia 1, but I wouldn't say that it requires bumping the minor version.

@fredrikekre
Copy link
Member

Yea thats fine. Wanna fix the other compat though?

@aminya
Copy link
Contributor

aminya commented Dec 14, 2019

Could you merge this? PackageCompiler needs this. JuliaLang/PackageCompiler.jl#293

[noblock]

aminya added a commit to aminya/PackageCompiler.jl that referenced this pull request Dec 14, 2019
Should fix JuliaLang#293.

WinRPM 0.4.3 should be merged to general registry (JuliaRegistries/General#6375).
aminya referenced this pull request in JuliaPackaging/WinRPM.jl Dec 14, 2019
UUID: c17dfb99-b4f7-5aad-8812-456da1ad7187
Repo: https://github.com/JuliaPackaging/WinRPM.jl.git
Tree: 859b5188afdcbede4a36a1876024937dfa876a51

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@github-actions
Copy link
Contributor

Your new version pull request does not meet the following guidelines for auto-merging:

  • A patch release is not allowed to narrow the supported ranges of Julia versions. The ranges have changed from Pkg.Types.VersionRange[VersionRange("0.7-1")] (in 0.4.2) to Pkg.Types.VersionRange[VersionRange("1")] (in 0.4.3).

Note: If your package works for the current version x.y.z of a dependency foo, then a compat entry foo = x.y.z implies a compatibility upper bound for packages following semver. You can additionally include earlier versionsyour package is compatible with. See [https://julialang.github.io/Pkg.jl/v1/compatibility/.] for details.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@nalimilan
Copy link
Contributor

Looks good now.

@KristofferC KristofferC merged commit 7d5cc04 into master Dec 16, 2019
@KristofferC KristofferC deleted the registrator/winrpm/c17dfb99/v0.4.3 branch December 16, 2019 11:53
@julia-tagbot
Copy link

julia-tagbot bot commented Dec 16, 2019

I've created release v0.4.3, here it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants