-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL start time fix #20
Conversation
This is awesome. 🤓👌🏻 |
Great! Confirmed to work on julia 1.2 and 1.3. |
@staticfloat Do you know what the Windows error is? |
It's fixed by BioJulia/Libz.jl@c82db8e but it needs a new version of |
I think this is ready but I'd like to see tests passing on Windows. Hopefully, there'll be a Libz.jl release fairly soon. |
@andreasnoack Thanks! With the new Libz.jl released, I did a test on my fork for windows (I do not have access to windows machines locally so only tested on appveyor), now it no longer complains about libz but errors at 7z.exe when building PackageCompiler... https://ci.appveyor.com/project/daviehh/mkl-jl/builds/29505379/job/3bth9m9vnka5y8bs#L93 Looks similar to error message on PackageCompiler's end: |
@staticfloat Do you know what the issue with 7z is? |
PackageCompiler is not looking in the right place for searchpath = ENV["PATH"]
if isdefined(Base, :LIBEXECDIR)
sepchar = Sys.iswindows() ? ";" : ":"
searchpath = string(joinpath(Sys.BINDIR, Base.LIBEXECDIR), sepchar, searchpath)
end
7z_path = withenv("PATH" => searchpath) do
Sys.which(`7z`)
end
run(`\$7z_path ...`) |
Okay. Unfortunately, it appears that Windows is currently not supported so let's get this one merged. We should probably switch to https://github.com/KristofferC/PackageCompilerX.jl once it has been released. |
I might hold off a bit with a new release since it might trigger a new build and therefore potentially break systems that are currently working. |
Fixing the Windows problem on PackageCompiler is a faster solution than switching to a different system. From what I remember, PackageCompilerX is not supported on Windows yet. |
Not true, it even has Windows CI. |
I have tested PackageCompilerX on mac and linux, it worked great for MKL.jl here, it should be easy to switch when PackageCompilerX is released. Also tested with JuliaLang/julia#30746 PR where the script saved precompile statements that PackageCompilerX can directly use. |
Thanks for clarification. I think I misunderstood some of your messages on Slack. |
Maybe, or the state of things changed since I wrote them :P |
The Windows problem should be fixed once JuliaRegistries/General#6375 and JuliaLang/PackageCompiler.jl#294 are merged. |
@andreasnoack You can tag a new release for MKL. I added a PR for V0.1 tagging: #22 New version of PkgCompiler is merged. This should solve the issue on Windows. |
Can fix the issue #1
Stock Julia without any packages:
MKL.jl
Fixed (after 1st run):
Also added current julia version (1.3) to travis test.
Note that according to the discussion in #1 one should generate precompile statements during the generation of sysimg, not after like here, but just replacing
force_native_image!()
withPackageCompiler.build_sysimg(PackageCompiler.default_sysimg_path(), "generate_precompile.jl")
does not work on my end...(does not replace :mkl https://travis-ci.com/daviehh/MKL.jl/builds/138789653)