Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for checking if the UUID of the dependencies is in the registry #361

Closed
wants to merge 2 commits into from

Conversation

SebastianM-C
Copy link
Contributor

Credit to @ericphanson

Rewrite dependency uuid check so that it gives a better error message when an UUID in depuuids is not in alluuids.

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>

Rewrite dependency uuid check so that it gives a better error message.
@DilumAluthge
Copy link
Member

Thanks @SebastianM-C!

I've merged #362, which is a tweaked version of this PR. I think that solves the issue - let me know if there are any remaining issues.

@bors bors bot closed this in 49c6058 Mar 14, 2021
@SebastianM-C
Copy link
Contributor Author

Thanks for the quick reply!
One possible enhancement would be to use a more general error message such that it accommodates the case where RegistryCI.jl is used in a custom registry (for example by mentioning the names or urls of the registries involved).

@SebastianM-C SebastianM-C deleted the deps_uuid branch March 14, 2021 17:03
@DilumAluthge
Copy link
Member

Hmm, well in that case, you know what the external registries are, right? You passed them in the registry_deps argument.

@SebastianM-C
Copy link
Contributor Author

Yeah, right. 🤔
I have a question regarding that usage. In a custom registry should the General registry be included in registry_deps if there are packages with dependencies in there?

@DilumAluthge
Copy link
Member

Yeah that's exactly what the registry_deps keyword argument is supposed to do.

I think you've found a bug. Bug fix here: #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants