Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSH_KEY for ssh #244

Closed
wants to merge 1 commit into from
Closed

Use SSH_KEY for ssh #244

wants to merge 1 commit into from

Conversation

ViralBShah
Copy link
Contributor

We had to do this in a couple of places for this to work reliably.

Example: JuliaInterop/RCall.jl#467

@DilumAluthge
Copy link
Member

It just depends on what you choose to name the secret in your repository settings. Many users already have a secret named DOCUMENTER_KEY in their repo (for use by Documenter.jl), so we chose that as a default. If your secret is named something different, you'll need to change the name in the workflow file to match the name of the secret. So there isn't one workflow file that will work for everyone out of the box. But I think DOCUMENTER_KEY is a decent default.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the name of the default, can you add a comment line explaining that users need to change this value to match whatever they chose to name their secret?

@ViralBShah
Copy link
Contributor Author

This is going beyond my understanding of github infra! Perhaps someone can update my PR or make a new one?

@ViralBShah ViralBShah closed this Nov 6, 2022
@DilumAluthge DilumAluthge deleted the vs/ssh-key branch November 6, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants