Skip to content

Commit

Permalink
small API default enhancements
Browse files Browse the repository at this point in the history
  • Loading branch information
dehann committed Nov 3, 2021
1 parent 913a934 commit 37f558e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/KernelHilbertEmbeddings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,6 @@ function mmd(a::ManifoldKernelDensity{M}, b::ManifoldKernelDensity{M}; bw::Vecto
end


function isapprox(a::ManifoldKernelDensity, b::ManifoldKernelDensity; atol::Real=0.1)
function isapprox(a::ManifoldKernelDensity, b::ManifoldKernelDensity; mmd_tol::Real=1e-1, atol::Real=mmd_tol)
mmd(a,b) < atol
end
2 changes: 1 addition & 1 deletion src/services/ManifoldKernelDensity.jl
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ end


# TODO check that partials / marginals are sampled correctly
function sample(x::ManifoldKernelDensity{M,B,L,P}, N::Int) where {M,B,L,P}
function sample(x::ManifoldKernelDensity{M,B,L,P}, N::Integer=1) where {M,B,L,P}
# get legacy matrix of coordinates and selected labels
coords, lbls = sample(x.belief, N)

Expand Down

0 comments on commit 37f558e

Please sign in to comment.