Add debug visualizer tool, increase tolerance in projection_weights #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 8 8
Lines 216 216
=======================================
Hits 204 204
Misses 12 12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice I found many more cases like #17 in 3D, specifically when the simplex is degenerate (points lie on the same plane in 3D). I found that increasing the tolerance (pretty significantly) fixed the issues. Again, I don't like tweaking epsilons like this (and there's definitely a trade-off, since I had to increase a tolerance for another test), but I'm not sure what the right way to do this is.