Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GJKResult/API changes #27

Merged
merged 2 commits into from
Jul 3, 2019
Merged

GJKResult/API changes #27

merged 2 commits into from
Jul 3, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Jul 3, 2019

Remove the signed_distance field from GJKResult, add in_collision and weights fields. Main reasons:

  • penetration distance computation often accounts for a a significant fraction of total computation time, while there are cases where it's not even needed. So make computing it optional by having it be in a separate method
  • I find the term signed_distance to be a bit disingenuous; in penetration we're not actually computing proper penetration distance. By having separate separation_distance and simplex_penetration_distance functions and talking about the difference in the readme, we're no longer lying.

@codecov-io
Copy link

Codecov Report

Merging #27 into master will decrease coverage by 1.87%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   94.54%   92.67%   -1.88%     
==========================================
  Files           8        8              
  Lines         220      232      +12     
==========================================
+ Hits          208      215       +7     
- Misses         12       17       +5
Impacted Files Coverage Δ
src/EnhancedGJK.jl 100% <ø> (ø) ⬆️
src/gjk.jl 93.18% <66.66%> (-5.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73fe0f...56c9302. Read the comment docs.

@tkoolen tkoolen mentioned this pull request Jul 3, 2019
@tkoolen tkoolen merged commit ccf6d94 into master Jul 3, 2019
@tkoolen tkoolen deleted the tk/result-api-changes branch July 3, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants