Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import Rotations as _Rotations #522

Closed
dehann opened this issue Oct 8, 2021 · 1 comment
Closed

import Rotations as _Rotations #522

dehann opened this issue Oct 8, 2021 · 1 comment
Assignees
@dehann
Labels
maintenance potential bug refactoring types upstream
Milestone
v0.17.0

Comments

@dehann
Copy link
Member

dehann commented Oct 8, 2021

Manifolds and Rotations have a name conflict on Rotations. Lets give Manifolds priority
@dehann dehann added this to the v0.0.x milestone Oct 8, 2021
dehann added a commit to JuliaRobotics/Caesar.jl that referenced this issue Oct 8, 2021
@dehann @Affie
import Rotations as _Rotations fix,
23d51bb 
See JuliaRobotics/RoME.jl#522

Co-authored-by: Johannes Terblanche <Affie@users.noreply.github.com>
@dehann dehann mentioned this issue Oct 8, 2021
Merged
@dehann dehann mentioned this issue Jan 2, 2023
Merged
@dehann dehann self-assigned this Jan 2, 2023
@dehann dehann modified the milestones: v0.0.x, v0.17.0 Jan 2, 2023
@dehann
Copy link
Member Author

dehann commented Jan 2, 2023

looks to have been done for some time.

@dehann dehann closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehann dehann

Labels
maintenance potential bug refactoring types upstream
Projects
Code Quality & Improvements
Status: Done
Milestone
v0.17.0
Development

No branches or pull requests
1 participant
@dehann