Use DFGVariable nanosecond time in Dyn #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehann
approved these changes
Aug 7, 2020
|
This and Masters pass, so merging |
dehann
reviewed
Aug 8, 2020
|
|
||
| global v1 = addVariable!(fg, :x1, DynPoint2(ut=1000_000)) | ||
| global v1 = addVariable!(fg, :x1, DynPoint2(ut=1000_000); nanosecondtime=10^9) |
There was a problem hiding this comment.
Hi @Affie , just checking here again and wondering if you don't want to drop the DynPoint(ut=1000000)? You should perhaps go as far as the rest of the code and just use the type DynPoint2 here. IIF will internally create the object when necessary.
There was a problem hiding this comment.
Hello, I left it in to trigger and test the deprecation on it.
I'll open an issue on T vs T() if that is what you mean.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs JuliaRobotics/IncrementalInference.jl#823