Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new flux factor test and update to CalcFactor #409

Merged
merged 5 commits into from
Feb 16, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Feb 12, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 12, 2021

Codecov Report

Merging #409 (58f2c45) into master (bae9dbb) will increase coverage by 3.42%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   21.19%   24.61%   +3.42%     
==========================================
  Files          44       43       -1     
  Lines        1779     1690      -89     
==========================================
+ Hits          377      416      +39     
+ Misses       1402     1274     -128     
Impacted Files Coverage Δ
src/RoME.jl 100.00% <ø> (ø)
src/factors/flux/MixtureFluxPose2Pose2.jl 50.00% <73.68%> (+50.00%) ⬆️
src/factors/Pose2D.jl 88.23% <0.00%> (+5.88%) ⬆️
src/CanonicalGraphs.jl 45.23% <0.00%> (+7.14%) ⬆️
src/factors/flux/models/Pose2OdoNN_01.jl 85.71% <0.00%> (+85.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faae3cb...58f2c45. Read the comment docs.

@Affie
Copy link
Member

Affie commented Feb 15, 2021

@dehann Please have a look at changes.

test/runtests.jl Outdated Show resolved Hide resolved
@dehann dehann marked this pull request as ready for review February 15, 2021 16:25
@Affie Affie changed the title new flux factor test new flux factor test and update to CalcFactor Feb 15, 2021
@Affie
Copy link
Member

Affie commented Feb 16, 2021

@dehann I think this one is ready to merge? 2 of the tests passed, other failing on numerics earlier on.

@dehann dehann merged commit 2defb91 into master Feb 16, 2021
@dehann
Copy link
Member Author

dehann commented Feb 16, 2021

Great, thanks for the help!

@Affie Affie linked an issue Feb 18, 2021 that may be closed by this pull request
@dehann dehann deleted the 21Q1/maint/calcfactorfluxtest branch March 6, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update CalcFactor API on Flux factors
3 participants