Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LANDMARK tags to landmarks in generator #530

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Conversation

GearsAD
Copy link
Collaborator

@GearsAD GearsAD commented Oct 17, 2021

Addresses #529

@GearsAD GearsAD requested review from dehann and Affie October 17, 2021 19:33
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #530 (4cbdf32) into master (16be65f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   30.97%   30.92%   -0.05%     
==========================================
  Files          49       49              
  Lines        2037     2037              
==========================================
- Hits          631      630       -1     
- Misses       1406     1407       +1     
Impacted Files Coverage Δ
src/canonical/GenerateHoneycomb.jl 95.38% <100.00%> (ø)
src/factors/Point2D.jl 51.85% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16be65f...4cbdf32. Read the comment docs.

@dehann dehann linked an issue Oct 17, 2021 that may be closed by this pull request
@GearsAD GearsAD merged commit db6ed8f into master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateCanonicalFG_Beehive! should put :LANDMARK tags on landmarks
3 participants