Online edits

[farhadrclass]

The first round,
I am adding my edits and notes into next push

[farhadrclass]

@paraynaud
one more push is to come soon to have FLuxNLP example

[paraynaud]

@farhadrclass I've allowed the generation of the .pdf (at least for your last commits).
You can take a look at the final result in details of the JOSS/.... job, then click on summary and look at the artifact !

[farhadrclass]

@dpo @paraynaud I added the examples of the FluxNLPModels with R2

[paraynaud]

Thanks for the work @farhadrclass.

Defining a neural network is a lot easier with Flux.
We should put the Knet.jl architecture and KnetNLPModel initialization into Annex, and make sure the code running for the remaining FluxNLPModel works also for the KnetNLPModel in Annex.

[farhadrclass]

@paraynaud ready for review

[farhadrclass]

@farhadrclass I've allowed the generation of the .pdf (at least for your last commits). You can take a look at the final result in details of the JOSS/.... job, then click on summary and look at the artifact !

I can not find this

[farhadrclass]

This is from: farhadrclass#1

Straightforward pass onto Summary + Statement of need + KnetNLPModel example.

What is left to do (beside FluxNLPModel example), e.g. comment not answered by the changes :

• mention : "It is important to stress that we want to be able to experiment with solvers that enforce a decrease of the merit function";
• answer : "Why not just write solvers directly in Flux.jl or Knet.jl";
• mention callback : but it appears in the example section.

After rebasing onto PR-JOSS-Flux and PR-JOSS:

• move Knet model definition to the end to put Flux architecture on the front (with a mention to the Knet model);
• make sure the code calling solver works for both models (same instruction, same callback ...)

[farhadrclass]

I added:

1. Example from FluxNLPModels
   1.1 Add accuracy to FluxNLPModels
   1.2 Added MinibatchNext to FluxNLPModels
   1.3 Simplify and clean the example
2. Write the example in Markdown and edit
3. Move the text (Flux before Knet)
4. Edit the first section
5. Edit the text overall
6. Apply @dpo remarks
7. Answer Why not just write solvers directly in Flux.jl or Knet.jl"; but I am not 100% sure if that is enough

@paraynaud please review and let me know what you think?

[paraynaud]

Nice work, thanks!