Add counters field in default counters macro #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigot
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks @MaxenceGollier , great idea!
Did you test it with NLPModelsModifiers?
Also, can you add a test for this here
NLPModels.jl/test/nlp/utils.jl
Line 20 in b8454fb
tmigot
reviewed
Jul 25, 2024
Yes, it works ! |
|
tmigot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this in NLPModelsModifiers#121.
The macro
default_countersshould now add the fieldcounterstoModel.I think this is the easiest solution.
If you are ok with this, could we update this package version for compatibility with
NLPModelsModifiers.jl?