Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to BinaryProvider #55

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Switch to BinaryProvider #55

merged 1 commit into from
Jun 13, 2018

Conversation

andreasnoack
Copy link
Member

Supersedes #48. All supported platforms are built for but obviously not tested.

Fixes #54

@andreasnoack
Copy link
Member Author

Looks like this is working. the failures on Linux is because gamma has been moved out of base.

@@ -1,3 +1,3 @@
julia 0.6
BinDeps 0.6.0
BinaryProvider 0.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's necessary from 0.3.2 that wasn't in 0.3.0 (or earlier?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been bug fixes added lately and it's the only version which has been tested so it's the only version known to work. Feel free to test prior versions and submit a PR if you can verify that it works for prior versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the bug fixes needed here? that's not what minimum versions are for. they are lowest version that should work based on features being used, not version that has been tested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello? You shouldn't release things that are just wrong.

@ararslan
Copy link
Member

Confirmed to work and pass all tests on FreeBSD with Julia 0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants