Include native version of reverse for InlineStrings #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first in a series of PRs where I'm going to attempt to provide "native" string functions that operate on and return InlineStrings. The advantage is that when working with InlineStrings, the normal set of string functions won't "poison" your data by unnecessarily introducing `String`s, but will operate directly on the InlineString type and return the same type when possible. The `reverse` function is a good example of that: it can always return the same type as the input, and in my benchmarks, it can be 2-4x faster than the "default" `String` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PRs where I'm going to attempt to
provide "native" string functions that operate on and return
InlineStrings. The advantage is that when working with InlineStrings,
the normal set of string functions won't "poison" your data by
unnecessarily introducing
Strings, but will operate directly on theInlineString type and return the same type when possible.
The
reversefunction is a good example of that: it can always returnthe same type as the input, and in my benchmarks, it can be 2-4x faster
than the "default"
Stringmethod.