Fix Parsers overloads #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tests on main branch due to recent changes in Parsers xparse dispatch.
nickrobinson251
approved these changes
Oct 12, 2022
| @@ -817,7 +820,7 @@ function Parsers.xparse(::Type{T}, source::Union{AbstractVector{UInt8}, IO}, pos | |||
| if overflowed | |||
| code |= Parsers.OVERFLOW | |||
| end | |||
| return Parsers.Result{S}(code, res.tlen, x) | |||
| return Parsers.Result{T}(code, res.tlen, x) | |||
There was a problem hiding this comment.
is S now entirely ignored by this xparse method? would passing a S != T have behaved differently before?
There was a problem hiding this comment.
Yes, essentially we're ignoring S now. Previously, I think that would have broken things.
There was a problem hiding this comment.
looks like we were actually relying on this JuliaData/CSV.jl#1033
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests on main branch due to recent changes in Parsers xparse dispatch.