Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation generator #558

Merged
merged 1 commit into from
May 8, 2024

Conversation

contradict
Copy link
Contributor

Strict is now the default, need to specify exceptiopns instead.

Strict is now the default, need to specify exceptiopns instead.
@github-actions
Copy link
Contributor

Benchmark Results

master 4a85971... t[master]/t[4a85971...]
overhead/acrule/a+2 1.07 ± 0.26 μs 1.07 ± 0.26 μs 1
overhead/acrule/a+2+b 1.06 ± 0.27 μs 1.07 ± 0.25 μs 0.991
overhead/acrule/a+b 0.354 ± 0.0077 μs 0.356 ± 0.0078 μs 0.993
overhead/acrule/noop:Int 26.3 ± 0.7 ns 26.2 ± 0.4 ns 1
overhead/acrule/noop:Sym 0.048 ± 0.008 μs 0.0468 ± 0.0078 μs 1.03
overhead/rule/noop:Int 0.0448 ± 0.0015 μs 0.0447 ± 0.0018 μs 1
overhead/rule/noop:Sym 0.0581 ± 0.002 μs 0.0581 ± 0.0019 μs 1
overhead/rule/noop:Term 0.0581 ± 0.0019 μs 0.0582 ± 0.0019 μs 0.998
overhead/ruleset/noop:Int 0.166 ± 0.0018 μs 0.166 ± 0.0023 μs 1
overhead/ruleset/noop:Sym 0.199 ± 0.0061 μs 0.189 ± 0.0043 μs 1.05
overhead/ruleset/noop:Term 4.34 ± 0.26 μs 4.29 ± 0.33 μs 1.01
overhead/simplify/noop:Int 0.223 ± 0.0092 μs 0.237 ± 0.0078 μs 0.94
overhead/simplify/noop:Sym 0.238 ± 0.0035 μs 0.251 ± 0.004 μs 0.947
overhead/simplify/noop:Term 0.0448 ± 0.004 ms 0.0455 ± 0.0037 ms 0.985
overhead/simplify/randterm (+, *):serial 0.162 ± 0.0012 s 0.163 ± 0.0023 s 0.996
overhead/simplify/randterm (+, *):thread 0.11 ± 0.015 s 0.113 ± 0.015 s 0.975
overhead/simplify/randterm (/, *):serial 0.282 ± 0.0087 ms 0.285 ± 0.0087 ms 0.989
overhead/simplify/randterm (/, *):thread 0.317 ± 0.0095 ms 0.324 ± 0.0094 ms 0.977
overhead/substitute/a 0.0755 ± 0.0015 ms 0.0721 ± 0.0016 ms 1.05
overhead/substitute/a,b 0.0649 ± 0.0016 ms 0.0636 ± 0.0016 ms 1.02
overhead/substitute/a,b,c 22.1 ± 0.6 μs 22 ± 0.7 μs 1
polyform/easy_iszero 0.0389 ± 0.0031 ms 0.0382 ± 0.0036 ms 1.02
polyform/isone 3.1 ± 0.1 ns 3.1 ± 0.1 ns 1
polyform/iszero 2.4 ± 0.033 ms 2.38 ± 0.032 ms 1.01
polyform/simplify_fractions 3.25 ± 0.035 ms 3.22 ± 0.039 ms 1.01
time_to_load 5.42 ± 0.051 s 5.4 ± 0.044 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@contradict contradict mentioned this pull request Oct 13, 2023
Copy link
Member

@bowenszhu bowenszhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The strict keyword argument to makedocs was removed and replaced with warnonly in Documenter.jl v1.0.0 in September 2023.

https://github.com/JuliaDocs/Documenter.jl/blob/027544a3bfb02f70abb8430ece508edaa35873b5/CHANGELOG.md?plain=1#L98-L113

@bowenszhu bowenszhu merged commit edb1689 into JuliaSymbolics:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants