refactor: add symbolic_type trait impl from SII #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/indexing-rework
branch
from
12f8990
to
81f9f6e
Compare
|
Well it doesn't pass, but it passes as much as master and Symbolics.jl master do 😅 |
|
What is this? |
|
Hi @AayushSabharwal, |
|
SymbolicIndexingInterface.jl (SII) is a package that implements symbolic indexing for the SciML ecosystem. It has a trait to identify symbolic variables (since they don't have a common subtype) which is implemented here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.