Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with #213 #218

Closed

Conversation

lgoettgens
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #218 (80dd482) into master (19a5588) will increase coverage by 12.34%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #218       +/-   ##
===========================================
+ Coverage   76.80%   89.14%   +12.34%     
===========================================
  Files          11       11               
  Lines         763      562      -201     
===========================================
- Hits          586      501       -85     
+ Misses        177       61      -116     
Flag Coverage Δ
unittests 89.14% <100.00%> (+12.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ambiguities.jl 89.76% <100.00%> (-0.08%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/code-style.yml Outdated Show resolved Hide resolved
.github/workflows/code-style.yml Outdated Show resolved Hide resolved
.github/workflows/code-style.yml Outdated Show resolved Hide resolved
.github/workflows/code-style.yml Outdated Show resolved Hide resolved
.github/workflows/code-style.yml Show resolved Hide resolved
@lgoettgens
Copy link
Collaborator Author

These suggestions should go to #213. This PR is only to test that everything works.

@lgoettgens
Copy link
Collaborator Author

Rebased this on top of the changes (@fingolfin's suggestions) in #213.

lgoettgens and others added 2 commits October 24, 2023 16:01
Co-authored-by: Max Horn <max@quendi.de>
@fingolfin
Copy link
Collaborator

Well, I find it quite cumbersome for experiments, I don't want to update two PRs. Maybe move the test commit in this PR to #213, close this one, and then can we can edit #213 until it works. And drop the "tests" once everything works

@hyrodium
Copy link
Contributor

Well, I find it quite cumbersome for experiments, I don't want to update two PRs. Maybe move the test commit in this PR to #213, close this one, and then can we can edit #213 until it works. And drop the "tests" once everything works

Thanks for the suggestion! I have updated #213, and now this PR can be closed.

@lgoettgens lgoettgens closed this Oct 25, 2023
@lgoettgens lgoettgens deleted the lg/experiment/formatter branch October 26, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants