Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of require lock since we're not multithreaded eval anymore #51

Merged
merged 1 commit into from
May 11, 2023

Conversation

quinnj
Copy link
Collaborator

@quinnj quinnj commented May 11, 2023

No description provided.

@@ -0,0 +1,163 @@
# This file is machine-generated - editing it directly is not advised
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this? Maybe we need a .gitignore for Manifest.tomls?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops; removed

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me! I think that this was somehow causing a deadlock on julia master, possibly because it's multithreading package loading or something? dunno.

@quinnj quinnj merged commit 3a3b425 into main May 11, 2023
@quinnj quinnj deleted the jq-remove-require-lock branch May 11, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants