-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework @test_reference
messages - drop lena
#118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
t-bltg
changed the title
rework log messages (only ci) - drop lena
rework Aug 10, 2022
@test_reference
messages - test messages (only ci) - drop lena
t-bltg
force-pushed
the
ci_lena
branch
2 times, most recently
from
August 11, 2022 11:07
c63dc5b
to
a39c7e9
Compare
t-bltg
changed the title
rework
rework Aug 11, 2022
@test_reference
messages - test messages (only ci) - drop lena@test_reference
messages - test msgs only on ci - drop lena
oxinabox
reviewed
Dec 5, 2022
johnnychen94
approved these changes
Dec 7, 2022
@oxinabox, I have some issues with nightly CI in UnicodePlots (see e.g. corrupted paths with ANSI codes in https://github.com/JuliaPlots/UnicodePlots.jl/actions/runs/7300585284/job/19895531268#step:6:384). This PR makes the output from Can we please revive and merge this PR and bump a new release (maybe @johnnychen94) ? |
t-bltg
changed the title
rework
rework Dec 22, 2023
@test_reference
messages - test msgs only on ci - drop lena@test_reference
messages - drop lena
CI is green for all OS. |
oxinabox
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@info
in@test_reference
: now includesrender(...)
(more structured output for the end user, see below, works well with images), this helps CI in ensuring correct message order (io flush);rework tests not to show spurious messages when working with@test_reference
macro unlessCI
env var is set totrue
: this was is very confusing when running] test ReferenceTests
: only the tests summary should be shown to the end user, detailed are activated in CI or by the env varCI
;lena
inruntests.jl
: replaced withmonarch
which is very similar (same format and size);test/references
: if testing is interrupted, these temporaries are leftovers, and thus can land in a commit (usemktempdir
instead).As an example, this job output (PR) is more readable than this one (master): most likely flush of
stdout
andstderr
is de-synchronized.PR
master