Fix for connectivity offset from WriteVTK #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah well. Clearly something with my whitespace formatting is still auto formatting. I'll leave this one up and try to figure out how I can eliminate that in the future. |
sloede
requested changes
Mar 31, 2023
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
sloede
reviewed
Mar 31, 2023
sloede
approved these changes
Mar 31, 2023
|
The Windows tests are failing due to a know (but intermittent) issue with decompression, thus I'll go forward and merge this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment connectivity in get_cells by one in order to match WriteVTK output. Had to increment the manual connectivity test case by one as well.
This is a partial fix for #21.