Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to be an org. #122

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Make it possible to be an org. #122

merged 1 commit into from
Oct 30, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Oct 30, 2018 •
edited
Loading

Before:

julia> GitHub.isorg(GitHub.Owner("Name", false))
false

julia> GitHub.isorg(GitHub.Owner("Name", true))
false

ararslan
ararslan reviewed Oct 30, 2018
View reviewed changes
src/owners/owners.jl
@@ -31,7 +31,7 @@ mutable struct Owner <: GitHubType
end

Owner(data::Dict) = json2github(Owner, data)
Owner(login::AbstractString, isorg = false) = Owner(Dict("login" => login, "typ" => isorg ? "User" : "Organization"))
Owner(login::AbstractString, isorg = false) = Owner(Dict("login" => login, "type" => isorg ? "Organization" : "User"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's an amusing oversight.

@ararslan
Copy link
Member

macOS failures are GitHub API rate limiting.

@ararslan ararslan merged commit 33f3bb5 into JuliaWeb:master Oct 30, 2018
@fredrikekre fredrikekre deleted the fe/orgs branch October 30, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @ararslan