Catch getsslcontext errors in server listenloop #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #318. This is a bad bug. Basically, if you're running an ssl server, any client who sends a non-perfect https request (like simply a plain *http* request) would result in the server task throwing an error and closing. This is partly because the thrown error isn't super obvious, nested down a few calls in our overloaded `Sockets.accept(::Server{SSLConfig})` method. The fix proposed here is that we'll put a try-catch in the ssl handshaking code and if an error is thrown, we return `nothing`; in the server `listenloop`, if the accepted `io` is `nothing`, then we'll skip and try to accept the next connection.
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 77.84% 78.23% +0.39%
==========================================
Files 37 37
Lines 2433 2440 +7
==========================================
+ Hits 1894 1909 +15
+ Misses 539 531 -8
Continue to review full report at Codecov.
|
|
Thanks for fixing this @quinnj! Very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318. This is a bad bug. Basically, if you're running an ssl
server, any client who sends a non-perfect https request (like simply a
plain http request) would result in the server task throwing an error
and closing. This is partly because the thrown error isn't super
obvious, nested down a few calls in our overloaded
Sockets.accept(::Server{SSLConfig})method. The fix proposed here isthat we'll put a try-catch in the ssl handshaking code and if an error
is thrown, we return
nothing; in the serverlistenloop, if theaccepted
ioisnothing, then we'll skip and try to accept the nextconnection.