Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for uppercase version of http proxy environment variables #648

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

racinmat
Copy link
Contributor

Fixes #646

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #648 (b9e98d0) into master (edc5e28) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   77.63%   77.45%   -0.18%     
==========================================
  Files          36       36              
  Lines        2325     2329       +4     
==========================================
- Hits         1805     1804       -1     
- Misses        520      525       +5     
Impacted Files Coverage Δ
src/HTTP.jl 100.00% <ø> (ø)
src/ConnectionRequest.jl 46.87% <50.00%> (-1.46%) ⬇️
src/RetryRequest.jl 55.00% <0.00%> (-5.00%) ⬇️
src/Messages.jl 92.48% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5e28...b9e98d0. Read the comment docs.

@quinnj quinnj merged commit f4857cc into JuliaWeb:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP requests does not respect HTTP_PROXY and HTTPS_PROXY environment variables
3 participants