Fix filepath name from remote URL in HTTP.download, fixes #696.

[fredrikekre]

No description provided.

[fredrikekre]

I noted that curl uses the filename of the original request URL rather than the redirect URL. That seems more intuitive to me but perhaps too big of a change?

[codecov-commenter]

Codecov Report

Merging #706 (15ff717) into master (255a759) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   75.24%   75.08%   -0.16%     
==========================================
  Files          36       36              
  Lines        2347     2352       +5     
==========================================
  Hits         1766     1766              
- Misses        581      586       +5     

Impacted Files	Coverage Δ
src/download.jl	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255a759...15ff717. Read the comment docs.

[oxinabox]

I noted that curl uses the filename of the original request URL rather than the redirect URL.

I think that would be fine.
Curl has good defaults, I always want HTTP.jl to act more like curl

[fredrikekre]

I agree. It is nice that HTTP.download("https://a.b/c") gives a file c since that is what I control, rather than what it happened to redirect to.

[fredrikekre]

I can update this PR with that before we merge.