Big update to cookie code #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our cookie code was originally ported from the golang stdlib implementation and this represents a (slightly overdue) update from the original source code. The biggest changes are a more solidified cookiejar implementation that is threadsafe and includes all the "getcookies!" and "setcookies!" implementations that we were hand-rolling previously. I also ported over some udpated tests. All in all, this seems like a great improvement IMO, and I'm going to go thru open cookie-related issues and make sure we get everything fixed.
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 78.48% 78.37% -0.12%
==========================================
Files 36 37 +1
Lines 2543 2705 +162
==========================================
+ Hits 1996 2120 +124
- Misses 547 585 +38
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cookie code was originally ported from the golang stdlib
implementation and this represents a (slightly overdue) update
from the original source code. The biggest changes are a more
solidified cookiejar implementation that is threadsafe and includes
all the "getcookies!" and "setcookies!" implementations that we
were hand-rolling previously. I also ported over some udpated tests.
All in all, this seems like a great improvement IMO, and I'm going
to go thru open cookie-related issues and make sure we get everything
fixed.