Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any string for parameter names in router, fixes #871. #872

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre fredrikekre requested a review from quinnj July 4, 2022 16:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #872 (271373c) into master (9fc906c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   80.01%   79.97%   -0.04%     
==========================================
  Files          36       36              
  Lines        2867     2867              
==========================================
- Hits         2294     2293       -1     
- Misses        573      574       +1     
Impacted Files Coverage Δ
src/Handlers.jl 82.80% <100.00%> (ø)
src/Messages.jl 86.95% <0.00%> (-0.63%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredrikekre!

@quinnj quinnj merged commit 447c086 into master Jul 4, 2022
@quinnj quinnj deleted the fe/router branch July 4, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants