Fix incorrect path normalization #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelmethod
force-pushed
the
kernelmethod/issue_20
branch
from
b912550
to
41e3de7
Compare
fonsp
suggested changes
May 17, 2022
fonsp
approved these changes
May 19, 2022
quinnj
reviewed
May 19, 2022
The old path normalization routine did not always normalize paths correctly, e.g., it did not handle paths ending in a "." correctly (see issue JuliaWeb#20). I've decided to fix this by rewriting normpath to run closer to its specification (as the `remove_dot_segments` function) described in IETF RFC 3986 [1]. Closes JuliaWeb#20. References: [1] https://datatracker.ietf.org/doc/html/rfc3986#section-5.2.4
Use prevind and nextind to identify the previous / next character in a string for the normpath function in order to make it Unicode-compatible. Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
kernelmethod
force-pushed
the
kernelmethod/issue_20
branch
from
64e43c9
to
782e6b6
Compare
|
Oops, sorry this slipped through the cracks on getting merged! Thanks @kernelmethod! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #20, by rewriting the
normpathroutine to operate more closely to its corresponding function in IETF RFC 3986 (theremove_dot_segmentsfunction described in Sec. 5.2.4).In addition to rewriting
normpath, I've added the "abnormal" test cases that triggered #20 to the test suite fornormpath. I've also added the full list of abnormal test cases described in Sec. 5.4 for theresolvereferencefunction, including the erroneous case, which should hopefully help catch errors like this more often.Closes #20.