Python 3 compatibility and reduced memory footprint on tail #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Python 3's strings have the __iter__ method and that breaks "t". Added this restriction. - Changed "tail" to avoid all the iterator in memory (only qte sized list is kept). All tests pass on Python 2 and 3
JulienPalard
added a commit
that referenced
this pull request
Feb 12, 2012
Python 3 compatibility and reduced memory footprint on tail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ton Python 3 (range converted to list).__iter__method and that breakst. Added type check.tailto avoid all the iterator in memory (only qte sized list is kept).All tests pass on Python 2 and 3