Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blind orientation on first call #362

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix blind orientation on first call #362

merged 1 commit into from
Dec 22, 2023

Conversation

pawlizio
Copy link
Collaborator

We should initiate with TargetPosition, otherwise Blind orientation can not be changed until position has been changed on HA start.

We should initiate with TargetPosition, otherwise Blind orientation can not be changed until position has been changed on HA start.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1fee9e) 79.97% compared to head (7b81cdb) 80.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   79.97%   80.00%   +0.02%     
==========================================
  Files          77       77              
  Lines        3560     3560              
==========================================
+ Hits         2847     2848       +1     
+ Misses        713      712       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawlizio pawlizio changed the title Update opening_device.py Fix blind orientation on first call Dec 16, 2023
@pawlizio
Copy link
Collaborator Author

Something is going wrong with github. It still shows me, that I'm 184 commits ahead...
image

@Julius2342
Copy link
Owner

Something is going wrong with github. It still shows me, that I'm 184 commits ahead...

Probably bc the large MR from you was squashed when merging. This creates one large commit - and therefore conflicts with your original clone.

@Julius2342 Julius2342 merged commit e545e4c into master Dec 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants